Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robotnik_pad_plugins/Movement: Allow plugin to check several axis fro… #24

Open
wants to merge 1 commit into
base: ros-devel
Choose a base branch
from

Conversation

jamendezib
Copy link
Contributor

@jamendezib jamendezib commented Dec 3, 2024

This pull request introduces several changes to the PadPluginMovement class in the robotnik_pad_plugins package to enhance the handling of accelerometer watchdog parameters and improve the robustness of the code. The most important changes include converting single-value parameters to vectors, adding a utility function to read parameters as vectors, and updating the logic to handle multiple accelerometer axes.

Enhancements to accelerometer watchdog handling:

Utility function addition:

Watchdog logic improvements:

  • robotnik_pad_plugins/src/movement_plugin.cpp: Modified the execute method to iterate over the axis_accel_watchdog_ vector and check each axis individually, updating the watchdog values and handling timeouts accordingly.

@jamendezib
Copy link
Contributor Author

jamendezib commented Dec 3, 2024

The main goal of this PR is to prevent the watchdog from triggering when the pad is in certain positions

@jamendezib
Copy link
Contributor Author

Tested in a RB-Robout. Works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant