-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
92 training pipeline #187
92 training pipeline #187
Conversation
…rint statements with logger for improved logging
…into 92_training_pipeline
… logging for training process, and improve error handling during model fitting
…bg_control into 92_training_pipeline
…bg_control into 92_training_pipeline
…g another sample model
…bg_control into 92-training-pipeline
…into 92_training_pipeline
…bg_control into 92-training-pipeline
Sorry for the delay @RobotPsychologist. I just finished configuring the unit tests so I think this issue should be done. |
No worries @jogong2718 thanks for doing this, seems like its still failing one test though. @Tony911029 do you have any thoughts on this? |
I will take a look now. @jogong2718 Can you invite me to your repo? I can take a look there. A bit hard for me fix this without seeing the actual branch locally |
@Tony911029 Just added you |
Config in linux server error is probably due to the two "meal_identification" folders. Check if it applies to you @Tony911029 and try both folder directories to see if the error persists. Also, you might need to add another meal identification to the config directory as well once you get config recognized. |
@NathanL15 I don't think it is nested meal_identification's issues because it ran before. I will do some comparison with existing main |
...identification/meal_identification/meal_identification/tests/model_training/test_modeling.py
Outdated
Show resolved
Hide resolved
@NathanL15 Fixed. I think you added some init so the package was imported from the wrong place |
@paulpark6 I think the test you just pushed failed |
Working on the issue, my bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are all these venv files in the PR? Why is there 876 files? lol!
0_meal_identification/meal_identification/notebooks/1.01-jg-GMMHMM-implementation.ipynb
Outdated
Show resolved
Hide resolved
…ebooks that somehow changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "update repo" commit may have caused the 897 file changes. I'm going to see if I can revert these changes.
7549447
to
9976e8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This init will cause some problems. Is there a reason why this is included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it. Im not sure why it was added I think it was to try and fix the module import issue but that didnt help.
Ok @RobotPsychologist @Tony911029 . Things should be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be good I don't see any immediate issues!
Finished the training script and awaiting review.
Additional details:
Note: When working with importing the ClusterSegmenter, the documentation for the module that the model is implemnted from the sktime website differed from the actual module name. The website states sktime.annotation.cluster when the actual module is sktime.annotation.clust.