Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmdb edges pointing the wrong direction #196

Open
cbizon opened this issue Jan 14, 2024 · 4 comments
Open

hmdb edges pointing the wrong direction #196

cbizon opened this issue Jan 14, 2024 · 4 comments
Assignees

Comments

@cbizon
Copy link
Contributor

cbizon commented Jan 14, 2024

Match (c:biolink:PhenotypicFeature {id:"HP:0002017"})-[a]-(x)-[b]-(d:biolink:ChemicalEntity {id:"PUBCHEM.COMPOUND:3776"}) return *

Shows a number of cases where x is a gene and there is an edge saying that the gene affects the abundance of d (the chemical). The edge is coming from HMDB.

image

This is almost certainly turned around the wrong way.

@cbizon
Copy link
Contributor Author

cbizon commented Apr 2, 2024

See also NCATSTranslator/Feedback#749.

I'm not sure that this is related. And looking back at this ticket, I'm not sure why I was convinced that the abundance edge was pointed the wrong direction. It could go either way, really. But I think we need to review the chemical/gene directions in HMDB overall.

@EvanDietzMorris
Copy link
Contributor

These edges are pointed in the other direction now. We did previously switch the direction of the affects_abundance_of edges too though, so we should double check that was correct.

@eKathleenCarter
Copy link
Contributor

For the affects_abundance_of edges I agree with Chris's above comment, it could go both ways. I am not sure how we would clarify which way the specific edge is pointing.

@cbizon
Copy link
Contributor Author

cbizon commented May 4, 2024

I think it's a question of going back to HMDB and reviewing whatever documentation they have about what their tables mean, and making sure that it's consistent with how we represent the dat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants