Skip to content

Commit

Permalink
APT-606 - Change Foreman To Install Internal Mirrors Instead Of Exter…
Browse files Browse the repository at this point in the history
…nal Tools APT-578 Upgrade setup-foreman to v3 (#390)

* modified setup-foreman to use v3 in all ci

* Fix valid type errors

---------
  • Loading branch information
RoFlection Bot committed Oct 17, 2023
1 parent 3faab3c commit 57b89fc
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions modules/react-noop-renderer/src/createReactNoop.lua
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ local function createReactNoop(reconciler, useMutation: boolean)
parentInstance: Instance,
child: Instance | TextInstance
): ()
if typeof(parentInstance.rootID) == "string" then
if typeof((parentInstance :: any).rootID) == "string" then
-- Some calls to this aren't typesafe.
-- This helps surface mistakes in tests.
error(Error("appendChild() first argument is not an instance."))
Expand Down Expand Up @@ -172,7 +172,7 @@ local function createReactNoop(reconciler, useMutation: boolean)
child: Instance | TextInstance,
beforeChild: Instance | TextInstance
)
if typeof(parentInstance.rootID) ~= "string" then
if typeof((parentInstance :: any).rootID) ~= "string" then
-- Some calls to this aren't typesafe.
-- This helps surface mistakes in tests.
error(Error("insertBefore() first argument is not an instance."))
Expand Down Expand Up @@ -211,7 +211,7 @@ local function createReactNoop(reconciler, useMutation: boolean)
end

local function removeChild(parentInstance: Instance, child: Instance | TextInstance)
if typeof(parentInstance.rootID) == "string" then
if typeof((parentInstance :: any).rootID) == "string" then
-- Some calls to this aren't typesafe.
-- This helps surface mistakes in tests.
error(Error("removeChild() first argument is not an instance."))
Expand Down

0 comments on commit 57b89fc

Please sign in to comment.