Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MarketplaceService.yaml #899

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Update MarketplaceService.yaml #899

merged 3 commits into from
Nov 4, 2024

Conversation

CoderzNation
Copy link
Contributor

@CoderzNation CoderzNation commented Nov 1, 2024

Fixed DisplaySubscriptionPeriod type being incorrectly set to a number instead of string

Changes

Just a type correction on the docs, I tried referencing this and got back /month instead of a number.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

Fixed DisplaySubscriptionPeriod type being incorrectly set to a number instead of string
@CoderzNation CoderzNation requested a review from a team as a code owner November 1, 2024 06:24
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Nov 1, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CoderzNation, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.

@aetter
Copy link
Contributor

aetter commented Nov 1, 2024

Hey @CoderzNation, this looks great, thanks for sending over. If you could check the three PR boxes in your initial comment, I'll get this merged. Thanks again.

@CoderzNation
Copy link
Contributor Author

Hey @aetter I checked those boxes!

Copy link

@CEO-jun CEO-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/en-us/reference/engine/classes/MarketplaceService.yaml

@aetter aetter merged commit dd4ffec into Roblox:main Nov 4, 2024
3 checks passed
@aetter
Copy link
Contributor

aetter commented Nov 4, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine reference Changes the Engine API Reference documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants