Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Camera.ViewportSize with behavior for notched devices #898

Merged
merged 27 commits into from
Nov 1, 2024
Merged

Update Camera.ViewportSize with behavior for notched devices #898

merged 27 commits into from
Nov 1, 2024
+87 −34

Conversation

ap4123
Copy link
Contributor

@ap4123 ap4123 commented Oct 31, 2024

Changes

Currently Camera.ViewportSize, FieldOfView, and DiagonalFieldOfView do not mention changes that were made to support notched devices. I updated these properties to describe the new behaviors.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@ap4123 ap4123 requested a review from a team as a code owner October 31, 2024 19:31
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Oct 31, 2024
@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Oct 31, 2024
@github-actions github-actions bot added the assets Changes content/en-us/assets/ label Nov 1, 2024
@IgnisRBX IgnisRBX merged commit 5f88496 into main Nov 1, 2024
3 checks passed
@IgnisRBX IgnisRBX deleted the addCameraSafeAreaInfo branch November 1, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@IgnisRBX IgnisRBX IgnisRBX approved these changes

Assignees
No one assigned
Labels
assets Changes content/en-us/assets/ changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ap4123 @IgnisRBX