Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad engine version #13

Closed
wants to merge 3 commits into from
Closed

fix: bad engine version #13

wants to merge 3 commits into from

Conversation

xhayper
Copy link
Contributor

@xhayper xhayper commented Aug 30, 2023

Changes

Fix bad engine version caused by improperly configured engines property in package.json

@octokit/rest 20.0.1 requires node version higher than 18, which conflicts with creator-docs's requirement of node version higher than 16.

This pull request also update the lockfile.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@xhayper xhayper requested a review from a team as a code owner August 30, 2023 00:25
@github-actions github-actions bot added the tools Makes non-content changes label Aug 30, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xhayper, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.

Copy link
Member

@tchu-roblox tchu-roblox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xhayper,

Thank you so much for taking the time to contribute to the Creator Docs repo. We really appreciate the effort you've put into this pull request.

However, I want to let you know that we're currently working on upgrading Node.js privately within the team. As a result, I’m afraid we won't be able to merge your pull request at this time.

The repo is still new, so we don't have a list of specific issues or features that we're focusing on publicly just yet, but we'd be thrilled to hear any other general feedback or suggestions you might have. Feel free to further comment or stay tuned as the project evolves. We'll definitely have more opportunities for contributors in the future.

Thanks again for your understanding and interest in contributing to Creator Docs. We really appreciate it and hope to see more contributions from you in the future.

Best regards,
Theodore

@xhayper
Copy link
Contributor Author

xhayper commented Aug 30, 2023

That is understandable!

@xhayper xhayper closed this Aug 30, 2023
@xhayper xhayper deleted the fix/bad-engine-version branch August 30, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Makes non-content changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants