Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

186 move complex logic from repositories to services #198

Merged
merged 12 commits into from
Apr 11, 2024

Conversation

Mnigos
Copy link
Member

@Mnigos Mnigos commented Apr 4, 2024

closes #186

@Mnigos Mnigos added the refactor label Apr 4, 2024
@Mnigos Mnigos added this to the rigtch.fm api v1 stable release milestone Apr 4, 2024
@Mnigos Mnigos requested a review from Iqro-dev April 4, 2024 13:05
@Mnigos Mnigos self-assigned this Apr 4, 2024
@Mnigos Mnigos force-pushed the 186-move-complex-logic-from-repositories-to-services branch from 757405d to a4406c8 Compare April 10, 2024 15:37
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 95.44199% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 86.39%. Comparing base (61f395b) to head (a4406c8).

Files Patch % Lines
src/modules/tracks/tracks.service.ts 93.27% 15 Missing ⚠️
...rc/common/abstractions/item.service.abstraction.ts 0.00% 9 Missing ⚠️
src/modules/history/history.service.ts 91.42% 6 Missing ⚠️
src/modules/images/images.service.ts 95.55% 2 Missing ⚠️
src/modules/albums/albums.service.ts 99.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   85.78%   86.39%   +0.60%     
==========================================
  Files          47       54       +7     
  Lines        2892     3220     +328     
  Branches      363      427      +64     
==========================================
+ Hits         2481     2782     +301     
- Misses        411      438      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mnigos Mnigos merged commit 77c3f14 into main Apr 11, 2024
5 checks passed
@Mnigos Mnigos deleted the 186-move-complex-logic-from-repositories-to-services branch April 11, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

move complex logic from repositories to services
2 participants