Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

152 refator adapters #156

Merged
merged 2 commits into from
Jan 29, 2024
Merged

152 refator adapters #156

merged 2 commits into from
Jan 29, 2024

Conversation

Mnigos
Copy link
Member

@Mnigos Mnigos commented Jan 19, 2024

closes #152

@Mnigos Mnigos changed the title 153 refator refresh token and callback 153 refator adapters Jan 19, 2024
@Mnigos Mnigos changed the title 153 refator adapters 152 refator adapters Jan 26, 2024
@Mnigos Mnigos marked this pull request as ready for review January 26, 2024 11:21
@Mnigos Mnigos self-assigned this Jan 26, 2024
@Mnigos Mnigos requested a review from Iqro-dev January 26, 2024 11:21
@Mnigos Mnigos force-pushed the 153-refator-refresh-token-and-callback branch from 63932f9 to a1e7604 Compare January 26, 2024 14:47
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (deeb98f) 85.87% compared to head (6c342b6) 85.81%.

Files Patch % Lines
src/modules/spotify/users/spotify-users.service.ts 5.55% 17 Missing ⚠️
src/common/adapters/adapters.service.ts 53.84% 12 Missing ⚠️
...c/modules/spotify/player/spotify-player.service.ts 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   85.87%   85.81%   -0.06%     
==========================================
  Files          30       31       +1     
  Lines        1423     1558     +135     
  Branches      147      185      +38     
==========================================
+ Hits         1222     1337     +115     
- Misses        201      221      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mnigos Mnigos force-pushed the 153-refator-refresh-token-and-callback branch from a1e7604 to 6c342b6 Compare January 26, 2024 19:08
@Mnigos Mnigos merged commit b827112 into main Jan 29, 2024
4 of 5 checks passed
@Mnigos Mnigos deleted the 153-refator-refresh-token-and-callback branch January 29, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

refactor adapters and lib types
2 participants