test(common/utils/catch-spotify-error): fix coverage

src/common/utils/catch-spotify-error.spec.ts

@@ -1,53 +1,78 @@
 import { test, describe, expect } from 'vitest'
 import { BadGatewayException, UnauthorizedException } from '@nestjs/common'
 
-import { catchSpotifyError } from './catch-spotify-error'
+import {
+  SPOTIFY_DEFAULT_ERROR_MESSAGE,
+  SpotifyAuthError,
+  catchSpotifyError,
+} from './catch-spotify-error'
 
 import { axiosResponseMockFactory } from '@common/mocks'
 
 describe('catchSpotifyError', () => {
   test('should throw UnauthorizedException', () => {
+    const message = 'Unauthorized'
+
     expect(() =>
       catchSpotifyError(
         axiosResponseMockFactory(
           {
             error: {
-              message: 'Unauthorized',
+              message,
               status: 401,
             },
           },
           401
         )
       )
-    ).toThrowError(UnauthorizedException)
+    ).toThrowError(new UnauthorizedException(message))
   })
 
   test('should throw UnauthorizedException as invalid grant', () => {
+    const message = 'Invalid token'
+
     expect(() =>
       catchSpotifyError(
         axiosResponseMockFactory(
           {
-            error: {
-              message: 'invalid_grant',
-              status: 401,
-            },
+            error: 'invalid_grant',
+            error_description: message,
           },
           401
         )
       )
-    ).toThrowError(UnauthorizedException)
+    ).toThrowError(new UnauthorizedException(message))
   })
 
-  test('should throw InternalServerErrorException', () => {
+  test('should throw BadGatewayException', () => {
+    const message = 'Bad Gateway'
+
     expect(() =>
       catchSpotifyError(
         axiosResponseMockFactory({
           error: {
-            message: 'Bad Gateway',
-            status: 500,
+            message,
+            status: 502,
           },
         })
       )
-    ).toThrowError(BadGatewayException)
+    ).toThrowError(
+      new BadGatewayException(SPOTIFY_DEFAULT_ERROR_MESSAGE + message)
+    )
+  })
+
+  test('should throw BadGatewayException', () => {
+    const message = 'Bad Gateway'
+
+    expect(() =>
+      catchSpotifyError(
+        axiosResponseMockFactory<SpotifyAuthError>({
+          error: message,
+          error_description: message,
+        })
+      )
+    ).toThrowError(
+      new BadGatewayException(SPOTIFY_DEFAULT_ERROR_MESSAGE + message)
+    )
   })
 })

src/common/utils/catch-spotify-error.ts

@@ -1,12 +1,12 @@
 import { BadGatewayException, UnauthorizedException } from '@nestjs/common'
 import { AxiosResponse } from 'axios'
 
-export abstract class SpotifyAuthError {
+export interface SpotifyAuthError {
   error: string
   error_description: string
 }
 
-export abstract class SpotifyError {
+export interface SpotifyError {
   error: {
     status: number
     message: string
@@ -17,18 +17,21 @@ export type SpotifyResponseError = AxiosResponse<
   SpotifyError | SpotifyAuthError
 >
 
+export const SPOTIFY_DEFAULT_ERROR_MESSAGE =
+  'Something went wrong with fetching data from spotify API:'
+
 export const catchSpotifyError = (response: SpotifyResponseError) => {
   console.log(response.data.error)
 
   const { data, status } = response
 
-  if (data instanceof SpotifyAuthError) {
+  if ('error_description' in data) {
+    console.log('ee')
     if (data.error === 'invalid_grant')
       throw new UnauthorizedException('Invalid token')
 
     throw new BadGatewayException(
-      'Something went wrong with fetching data from spotify API',
-      data?.error_description
+      SPOTIFY_DEFAULT_ERROR_MESSAGE + data.error_description
     )
   }
 
@@ -37,7 +40,6 @@ export const catchSpotifyError = (response: SpotifyResponseError) => {
   if (status === 401) throw new UnauthorizedException(data.error.message)
 
   throw new BadGatewayException(
-    'Something went wrong with fetching data from spotify API',
-    data.error.message
+    SPOTIFY_DEFAULT_ERROR_MESSAGE + data.error.message
   )
 }