Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add directory services enumeration #447

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Add directory services enumeration #447

merged 7 commits into from
Aug 6, 2024

Conversation

chebuya
Copy link
Contributor

@chebuya chebuya commented Aug 1, 2024

Add module for directory services enumeration

nobodynate
nobodynate requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@nobodynate nobodynate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working when --region is correct.
Getting error when region is incorrect, which causes issues when region is not specified and correct.
Maybe adding error handling for the case when there is not a deployment in the specified region will help

@chebuya
Copy link
Contributor Author

chebuya commented Aug 5, 2024

Fixed issue with all regions, should be good now!

Working when --region is correct. Getting error when region is incorrect, which causes issues when region is not specified and correct. Maybe adding error handling for the case when there is not a deployment in the specified region will help

nobodynate
nobodynate approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@nobodynate nobodynate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working. thanks!

@nobodynate nobodynate merged commit bdaad8b into master Aug 6, 2024
3 checks passed
@nobodynate nobodynate deleted the ds_enum branch August 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobodynate nobodynate nobodynate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chebuya @nobodynate