Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-1911] Track billing email entry events #287

Merged
merged 8 commits into from
Jan 31, 2025
Merged

[WEB-1911] Track billing email entry events #287

merged 8 commits into from
Jan 31, 2025

Conversation

polmiro
Copy link
Member

@polmiro polmiro commented Jan 30, 2025 •
edited
Loading

Motivation / Description

Adds tracking events for the billing email entry screen:

  • impression
  • submission
  • error
  • close

Changes introduced

  • Add (new) UI tests for testing svelte component behaviors fast without a fully feature e2e.
  • Add the tracking for the events.
  • Renamed / Rearranged some of the tests files.

@polmiro polmiro changed the base branch from main to user-events January 30, 2025 16:08
@polmiro polmiro changed the base branch from user-events to web-1910 January 30, 2025 16:09
@polmiro polmiro changed the title [WEB-1911] Track billing eail entry events [WEB-1911] Track billing email entry events Jan 30, 2025
@nicfix nicfix requested a review from a team January 31, 2025 10:07
@polmiro polmiro force-pushed the web-1911 branch 5 times, most recently from 01f2bdc to 7803a39 Compare January 31, 2025 11:23
@polmiro polmiro marked this pull request as ready for review January 31, 2025 11:26
Base automatically changed from web-1910 to user-events January 31, 2025 14:15
nicfix
nicfix reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@nicfix nicfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions.

The most important is to reduce the number of setContext calls.

src/ui/states/state-needs-auth-info.svelte Outdated Show resolved Hide resolved
src/ui/rcb-ui.svelte Show resolved Hide resolved
@polmiro polmiro merged commit 36c555f into user-events Jan 31, 2025
5 checks passed
@polmiro polmiro deleted the web-1911 branch January 31, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero left review comments

@nicfix nicfix nicfix approved these changes

Assignees
No one assigned
Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polmiro @tonidero @nicfix