Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped views #282

Merged
merged 67 commits into from
Feb 3, 2025
Merged

Conversation

alfondotnet
Copy link
Member

@alfondotnet alfondotnet commented Jan 27, 2025

First pass at revamping our purchase flow.

Keep in mind this PR goes against a branch fon/new-sdk-views. I'd love feedback on what we have until now

Things left to do:

  • @iga-gawronska Needs to figure out sizing adjustments to our Stripe form
  • Need to implement floating labels for the e-mail form (but lower priority)
  • Need to add controls to Storybook for the different appearances (and see if I can fix the fact that there's implementation duplication in the stories)
  • Clean up the Stripe file onto a hook-like file
  • Translate the texts I have changed to all other languages

@alfondotnet alfondotnet changed the base branch from main to fon/new-sdk-views January 27, 2025 22:49
- update naming of spacing variables
- add outerPaddingSmall
@alfondotnet alfondotnet changed the title [Draft] revamped views Revamped views Jan 31, 2025
@alfondotnet
Copy link
Member Author

alfondotnet commented Jan 31, 2025 via email

@alfondotnet alfondotnet force-pushed the web-1958-sdk-revamp-email-entry-page branch from 2d2b481 to b10a550 Compare February 3, 2025 20:59
@alfondotnet alfondotnet merged commit e31050d into fon/new-sdk-views Feb 3, 2025
4 of 5 checks passed
@alfondotnet alfondotnet deleted the web-1958-sdk-revamp-email-entry-page branch February 3, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants