Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/purchase-flow-need-auth-info accessibility improvements #280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tuuben
Copy link

@Tuuben Tuuben commented Jan 23, 2025

Motivation / Description

Hey, I was going through the codebase to familiarize myself with it and noted some accessibility stuff is missing from inputs and buttons so thought I'd commit a small fix for it. Feel free to just disregard this PR incase it's not relevant / other internal changes incoming 😊

Changes introduced

  • Fixes email input to display the correct keyboard type (email) on virtual keyboards.
  • Fixes close button focus with screen readers.
  • Improves email input descriptions with screen readers.
  • Explicitly sets tabIndex for safari browsers to make buttons tab focusable, issue described here

Linear ticket (if any)

Additional comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant