Add per-Task cpu time metric (#56320) #194
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initialize to zero make new task field visible from Julia add start time fix typo add test add a wait import `LinearAlgebra` for `peakflops` update last scheduled on task finish as well no need to update last scheduled in finish add test fix test Add per-task wall-time Test individual task cpu_time less than wall_time More tests Move task timings mostly to julia Record cpu time on entrance to `wait/yield` Rename 'scheduled_at' -> '[en/de]queued_at' Ability to enable/disable task timings globally fixup whitespace Enable task timing in test Enable task timing for root task Prevent `task_timing(false)` decrementing below zero Change task-timing flag to require yes/no arg Rename `timings`->`metrics`, `dequeued`->`started_running` Update task-state-transition comments Remove unused debug function Add NEWS Add fallback recording of cpu time in `wait()` Instrument async io Record task cpu time in `wait()` Make task metrics flag const and counters atomic Mark the new APIs experimental Return task metrics as Int or nothing if disabled Test metrics updating as expected More tests
github-actions
bot
added
port-to-v1.10
nickrobinson251
removed
the
port-to-master
for the running task only. Other tasks report metrics that are non-continuous but updated only on task switches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
"Backports" JuliaLang#56320 (note upstream PR not merged yet and so subject to change that'd need to be cherry-picked to here)
This PR should be squashed when merged
Checklist
Requirements for merging:
port-to-*labels that don't apply.