Change heartbeat thread controls #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
port-to-v1.10
NHDaly
reviewed
Nov 14, 2023
NHDaly
reviewed
Nov 14, 2023
NHDaly
approved these changes
Nov 14, 2023
NHDaly
reviewed
Nov 14, 2023
NHDaly
approved these changes
Nov 14, 2023
When enabling heartbeats, the user must specify: - heartbeat_s: jl_heartbeat() must be called at least once every heartbeat_s; if it isn't, a one-line heartbeat loss report is printed - show_tasks_after_n: after these many heartbeat_s have passed without jl_heartbeat() being called, print task backtraces and stop all reporting - reset_after_n: after these many heartbeat_s have passed with jl_heartbeat() being called, print a heartbeats recovered message and reset reporting
kpamnany
force-pushed
the
kp-tweak-hb
branch
from
b343945
to
be04cc4
Compare
kpamnany
removed
the
port-to-v1.10
Drvi
added
port-to-v1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
When enabling heartbeats, the user must now specify:
heartbeat_s:jl_heartbeat()must be called at least once everyheartbeat_s; if it isn't, a one-line heartbeat loss report is printedshow_tasks_after_n: after these manyheartbeat_shave passed withoutjl_heartbeat()being called, print task backtraces and stop all reportingreset_after_n: after these manyheartbeat_shave passed withjl_heartbeat()being called, reset reportingChecklist
Requirements for merging:
[ ] I have opened an issue or PR upstream on JuliaLang/julia: <link to JuliaLang/julia>port-to-*labels that don't apply.