Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: don't set pool_live_bytes to zero at the end of GC #107

Merged
merged 1 commit into from
Nov 7, 2023
Merged

bugfix: don't set pool_live_bytes to zero at the end of GC #107

merged 1 commit into from
Nov 7, 2023

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Nov 7, 2023

PR Description

One more bugfix related to the pool_live_bytes metric.

Ran one of the large scale customer benchmarks and sanity-checked the metric on that. Also sanity-checked on a micro GCBenchmark. Hopefully will be the last bugfix coming from that PR.

Checklist

Requirements for merging:

@d-netto d-netto requested a review from kpamnany November 7, 2023 13:21
@github-actions github-actions bot added port-to-v1.10 This change should apply to Julia v1.10 builds port-to-master This change should apply to all future Julia builds port-to-v1.9 This change should apply to Julia v1.9 builds labels Nov 7, 2023
@d-netto d-netto removed the port-to-master This change should apply to all future Julia builds label Nov 7, 2023
@d-netto d-netto merged commit 6afe64e into v1.9.2+RAI Nov 7, 2023
3 checks passed
@d-netto d-netto deleted the dcn-pool-live-bytes branch November 7, 2023 17:02
@kpamnany kpamnany removed the port-to-v1.10 This change should apply to Julia v1.10 builds label Nov 16, 2023
kpamnany pushed a commit that referenced this pull request Nov 16, 2023
@d-netto @kpamnany
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
7394bf5
d-netto added a commit that referenced this pull request Nov 28, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
4858064
DelveCI pushed a commit that referenced this pull request Nov 29, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
1d217f8
DelveCI pushed a commit that referenced this pull request Dec 3, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
041eadc
DelveCI pushed a commit that referenced this pull request Dec 4, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
1a98db2
@Drvi Drvi added port-to-v1.9 This change should apply to Julia v1.9 builds and removed port-to-v1.9 This change should apply to Julia v1.9 builds labels Dec 7, 2023
Drvi pushed a commit that referenced this pull request Dec 7, 2023
@d-netto @Drvi
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
0210774
DelveCI pushed a commit that referenced this pull request Dec 13, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
8d4840b
DelveCI pushed a commit that referenced this pull request Dec 17, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
5da704d
DelveCI pushed a commit that referenced this pull request Dec 18, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
ca2c8ba
DelveCI pushed a commit that referenced this pull request Dec 19, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
6646a51
DelveCI pushed a commit that referenced this pull request Dec 23, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
8ca38a8
DelveCI pushed a commit that referenced this pull request Dec 24, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
ed4d91c
DelveCI pushed a commit that referenced this pull request Dec 25, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
ca29e0f
DelveCI pushed a commit that referenced this pull request Dec 26, 2023
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
0714cba
@d-netto d-netto removed the port-to-v1.9 This change should apply to Julia v1.9 builds label Jan 2, 2024
DelveCI pushed a commit that referenced this pull request Jan 6, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
6c763d2
Drvi pushed a commit that referenced this pull request Jan 8, 2024
@d-netto @Drvi
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
f55c4cb
DelveCI pushed a commit that referenced this pull request Jan 13, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
c42a670
DelveCI pushed a commit that referenced this pull request Jan 17, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
5893f65
DelveCI pushed a commit that referenced this pull request Jan 18, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
097f18b
DelveCI pushed a commit that referenced this pull request Jan 23, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
db2efe5
DelveCI pushed a commit that referenced this pull request Jan 24, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
8ef8409
DelveCI pushed a commit that referenced this pull request Jan 25, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
bc427b9
DelveCI pushed a commit that referenced this pull request Jan 27, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
ce33786
DelveCI pushed a commit that referenced this pull request Jan 30, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
aeccb0f
DelveCI pushed a commit that referenced this pull request Jan 31, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
af7d434
DelveCI pushed a commit that referenced this pull request Feb 1, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
c40eb6e
DelveCI pushed a commit that referenced this pull request Feb 6, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
436c064
DelveCI pushed a commit that referenced this pull request Feb 7, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
8d3854b
DelveCI pushed a commit that referenced this pull request Feb 14, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
544bc9b
DelveCI pushed a commit that referenced this pull request Feb 21, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
9619e0a
DelveCI pushed a commit that referenced this pull request Feb 22, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
26933f6
Drvi pushed a commit that referenced this pull request Feb 28, 2024
@d-netto @Drvi
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
94ad202
DelveCI pushed a commit that referenced this pull request Mar 1, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
b351973
DelveCI pushed a commit that referenced this pull request Mar 13, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
e1b0d2c
Drvi pushed a commit that referenced this pull request Apr 3, 2024
@d-netto @Drvi
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
cf5f6fb
d-netto added a commit that referenced this pull request Apr 16, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
2e4ed2e
DelveCI pushed a commit that referenced this pull request Apr 23, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
b5d9fad
DelveCI pushed a commit that referenced this pull request Apr 24, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
fa46bb4
DelveCI pushed a commit that referenced this pull request Apr 30, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
f674cf0
DelveCI pushed a commit that referenced this pull request Apr 30, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
5734b5f
DelveCI pushed a commit that referenced this pull request May 2, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
9630dec
DelveCI pushed a commit that referenced this pull request May 9, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
f7b037c
DelveCI pushed a commit that referenced this pull request May 19, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
cb75b62
DelveCI pushed a commit that referenced this pull request May 26, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
3834b7d
DelveCI pushed a commit that referenced this pull request May 28, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
285b887
DelveCI pushed a commit that referenced this pull request May 29, 2024
@d-netto
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
816a5d5
Drvi pushed a commit that referenced this pull request Jun 7, 2024
@d-netto @Drvi
bugfix: don't set pool_live_bytes to zero at the end of GC (#107)
c7cf2e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpamnany kpamnany kpamnany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-netto @kpamnany @Drvi