bugfix: load jl_n_threads in jl_gc_pool_live_bytes (#52034) #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets it to 0 in the very end of its body) and this function becomes a no-op.
github-actions
bot
added
port-to-v1.10
d-netto
removed
the
port-to-master
kpamnany
approved these changes
Nov 6, 2023
kpamnany
removed
the
port-to-v1.10
Drvi
added
port-to-v1.9
Drvi
pushed a commit
that referenced
this pull request
Dec 7, 2023
…106) Otherwise we may just observe `gc_n_threads = 0` (`jl_gc_collect` sets it to 0 in the very end of its body) and this function becomes a no-op.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Otherwise we may just observe
gc_n_threads = 0(jl_gc_collectsets it to 0 in the very end of its body) and this function becomes a no-op.Checklist
Requirements for merging:
port-to-*labels that don't apply.