Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split target of dotnet library versions #607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Split target of dotnet library versions #607

wants to merge 1 commit into from

Conversation

Turnerj
Copy link
Collaborator

@Turnerj Turnerj commented Jun 8, 2023

This will make only .NET 7 pull in v7 of core .NET libraries. Fixes #598

The downside to this is that Renovate and Dependabot will likely struggle updating System.Text.Json now so we will need to be extra careful.

@Turnerj Turnerj added dependencies Pull requests that update a dependency file. maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. patch Pull requests requiring a patch version update according to semantic versioning. labels Jun 8, 2023
@github-actions github-actions bot added the enhancement Issues describing an enhancement or pull requests adding an enhancement. label Jun 8, 2023
@Turnerj Turnerj requested a review from RehanSaeed June 8, 2023 12:48
@Turnerj Turnerj removed the enhancement Issues describing an enhancement or pull requests adding an enhancement. label Jun 8, 2023
@kirk-marple
Copy link
Contributor

@RehanSaeed Would there be a chance to get this merged in? We've been holding off upgrading to latest package for months because of this, and would really appreciate it, thanks!

@RehanSaeed
Copy link
Owner

Strange that we have to do this. Approved.

@Turnerj
Split target of dotnet libraries
38fa7b9 
This will make only .NET 7 pull in v7 of core .NET libraries
@Turnerj Turnerj force-pushed the split-target-of-dotnet-libraries branch from 4453c29 to 38fa7b9 Compare December 23, 2023 04:40
@github-actions github-actions bot added the enhancement Issues describing an enhancement or pull requests adding an enhancement. label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RehanSaeed RehanSaeed RehanSaeed approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. enhancement Issues describing an enhancement or pull requests adding an enhancement. maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. patch Pull requests requiring a patch version update according to semantic versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 12.0.0 has a dependency on .NET 7 in the .NET 6 build
3 participants
@Turnerj @kirk-marple @RehanSaeed