Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python 3.13 support #61

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

GitRon
Copy link
Contributor

@GitRon GitRon commented Dec 6, 2024

Hi @lociii

just came across this. 🙂

Best
Ronny

@lociii
Copy link
Member

lociii commented Jan 9, 2025

Thanks once more for the proposal. Would you mind adding exclusions for unsupported Django releases with Python 3.13?

jobs:
  test:
    strategy:
      matrix:
        exclude:
          - python-version: "3.13"
            django: "4.2"
          - python-version: "3.13"
            django: "5.0"

Thanks.

@lociii lociii assigned lociii and GitRon and unassigned lociii Jan 9, 2025
@GitRon
Copy link
Contributor Author

GitRon commented Jan 12, 2025

Hi @lociii!

May I ask why? The pipeline seems to pass, right? 🙂

@lociii
Copy link
Member

lociii commented Jan 13, 2025

Sure. It's not officially supported.
See https://docs.djangoproject.com/en/5.1/releases/4.2/#python-compatibility and https://docs.djangoproject.com/en/5.1/releases/5.0/#python-compatibility

We once decided against testing unsupported combinations as this might lead to the impression that they're supported by us. Even though the tests may pass, we don't know if everything untested works properly. Therefore we would like to exclude such combinations as we would also not provide any support/help for them.

@GitRon
Copy link
Contributor Author

GitRon commented Jan 14, 2025

Hi @lociii

that sounds reasonable. Will to the fix.

Best
Ronny

@lociii
Copy link
Member

lociii commented Jan 15, 2025

Thanks. Do you already use 3.13?
Asking to know how urgent a new release is. :)

@lociii lociii merged commit 9f34426 into RegioHelden:master Jan 15, 2025
38 checks passed
@GitRon GitRon deleted the feature/python-313-support branch January 15, 2025 08:57
@GitRon
Copy link
Contributor Author

GitRon commented Jan 15, 2025

Thx ❤️


Not yet but will start upgrading my projects since 3.13.1 is out. I always wait for the first patch release 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants