-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented simple //write for binary values (#268) #269
base: dev
Are you sure you want to change the base?
Conversation
The default on block should be a redstone block, the fact that lamps turn off when updated is normal |
Looks good, lmk when you're done editing & testing |
I can't find any more errors and have nothing more to implement, somebody else should still test it though |
35c098f
to
848dd1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still has some issues, see comment above
…re/binary-write # Conflicts: # src/main/java/tools/redstone/redstonetools/features/commands/BinaryBlockWriteFeature.java
They should be fixed now |
src/main/java/tools/redstone/redstonetools/features/commands/BinaryBlockWriteFeature.java
Outdated
Show resolved
Hide resolved
Please mention the issue next time so your PR shows up on the issue. |
I had the issue in the name, so that doesn't work, so I'll do it next time in the comment |
fixed both problems |
This behaves rather weirdly imo, when you select 7 blocks (b a b a b a b, where b is a block and a is air) and try to write a 4 bit number it'll tell you the selection isnt a multiple of the bit count when I think its a perfectly valid input. I think we're gonna have to postpone this feature and add it after the refactor |
… first to the last bit
It was pretty easy to fix, if you want to test it again, it should now work |
This seems to be a problem of the feedback formatting, the only thing I could do about it, is to shorten the text |
Simple implementation for a write command, still needs testing, only bug found for now is the redstonelamps turning off, if there is one updated next to them