Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Fix 32-bit Windows build #868

Merged

Conversation

Spartan322
Copy link
Member

@Spartan322 Spartan322 commented Nov 17, 2024

Causes godotengine/godot#99108 conversion errors on 32-bit Windows because size_t on 32-bit is unsigned int whereas on 32-bit Windows' SIZE_T is unsigned long. This is how it was solved for godotengine/godot#99107 with godotengine/godot#99280.

(cherry picked from commit 287b754)
@Spartan322 Spartan322 force-pushed the 4.3-fix/win32-sizet-conv-errors branch from a5792dd to f310921 Compare November 17, 2024 15:52
@Spartan322 Spartan322 changed the title [4.3] Fix size_t attr_list_size to SIZE_T attr_list_size [4.3] Fix 32-bit Windows build Nov 17, 2024
@Spartan322 Spartan322 merged commit 364a394 into Redot-Engine:4.3 Nov 17, 2024
18 checks passed
@Spartan322 Spartan322 deleted the 4.3-fix/win32-sizet-conv-errors branch November 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants