Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate configurable rules severity overrides correctly in config #1872

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Jan 30, 2025

What/Why/How?

Resolved an issue where overrides for the severity of configurable rules raised warnings when validating the config.

Reference

Closes #1865

It's a follow-up to #1811

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr self-assigned this Jan 30, 2025
Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: f52ec01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tatomyr tatomyr marked this pull request as ready for review January 30, 2025 19:30
@tatomyr tatomyr requested review from a team as code owners January 30, 2025 19:30
Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 965.6 ± 14.2 948.3 985.1 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 966.9 ± 17.3 946.5 998.5 1.00 ± 0.02

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.6% 5053/6429
🟡 Branches 67.18% 2059/3065
🟡 Functions 73.16% 834/1140
🟡 Lines 78.88% 4767/6043
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / redocly-yaml.ts
81.54% (-1.79% 🔻)
47.37% (-2.63% 🔻)
71.43%
81.1% (-1.82% 🔻)

Test suite run success

835 tests passing in 120 suites.

Report generated by 🧪jest coverage report action from f52ec01

@Marshevskyy Marshevskyy merged commit fa280a3 into main Jan 31, 2025
43 checks passed
@Marshevskyy Marshevskyy deleted the fix/configurable-rules-severity-highlighting branch January 31, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to re-configure severity of configurable rules
3 participants