remove twitter endpoint (#51)

* how do you like this, Elon Musk?

* blacked

* Unused imports remove

* Unused import

* Add upgrade step

* Update profile version

* Blacked

* FIx

* black

---------

Co-authored-by: Mauro Amico <[email protected]>

CHANGES.rst

@@ -4,7 +4,8 @@ Changelog
 5.0.4 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Remove twitter feeds.
+  [folix-01]
 
 
 5.0.3 (2023-06-13)

README.rst

@@ -164,51 +164,6 @@ La struttura degli attachments è la seguente::
 
 Se l'invio va a buon fine, viene tornata una risposta con `204`.
 
-@twitter-feed
--------------
-
-Endpoint per poter visualizzare una serie di tweet.
-
-Per poterla utilizzare, bisogna creare un'app su Twitter e impostare il token Bearer dentro al registry Plone nella entry *design.plone.policy.twitter_token*.
-
-Per fare la ricerca, utilizza l'endpoint `recent`_ che permette di visualizzare solo i tweet dell'ultima settimana.
-
-.. _recent: https://developer.twitter.com/en/docs/twitter-api/tweets/search/introduction
-
-Come parametri accetta i seguenti:
-
-- **authors**: una lista di username tra cui ricercare gli ultimi Tweet.
-- **max_results**: un numero tra 10 e 100.
-
-Esempio di chiamata::
-
-    > curl -i -X GET http://localhost:8080/Plone/@twitter-feed?authors=foo&authors=bar -H 'Accept: application/json' -H 'Content-Type: application/json'
-
-La risposta è una lista di tweet con le informazioni necessarie per essere renderizzati::
-
-    [
-        {
-            "author": {
-            "id": "12345678",
-            "name": "John Doe",
-            "profile_image_url": "https://pbs.twimg.com/profile_images/xxx/xxx_normal.jpg",
-            "username": "jdoe"
-            },
-            "id": "xxxxx",
-            "like_count": 1,
-            "reply_count": 0,
-            "retweet_count": 0,
-            "text": "stringa html"
-        },
-        ...
-    ]
-
-Il campo `text` contiene già eventuali link ad hashtag, menzioni e link esterni dentro ad un tag <a/>.
-
-**Per evitare troppe chiamate al servizio (c'è un limite di 500000 tweet al mese), c'è della cache: per ogni query
-i risultati rimangono in cache per mezz'ora.**
-
-
 Amministrazione trasparente
 ===========================
 

src/design/plone/policy/interfaces.py

@@ -1,7 +1,6 @@
 # -*- coding: utf-8 -*-
 """Module where all interfaces, events and exceptions live."""
 
-from zope import schema
 from zope.interface import Interface
 from zope.publisher.interfaces.browser import IDefaultBrowserLayer
 
@@ -11,4 +10,4 @@ class IDesignPlonePolicyLayer(IDefaultBrowserLayer):
 
 
 class IDesignPlonePolicySettings(Interface):
-    twitter_token = schema.TextLine(title="Twitter Bearer token")
+    """IDesignPlonePolicySettings interface"""

src/design/plone/policy/profiles/default/metadata.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <metadata>
-  <version>3100</version>
+  <version>3101</version>
   <dependencies>
     <dependency>profile-plone.restapi:default</dependency>
     <dependency>profile-design.plone.contenttypes:default</dependency>

src/design/plone/policy/restapi/configure.zcml

@@ -7,6 +7,5 @@
 
   <include package=".bandi_search_filters" />
   <include package=".search_filters" />
-  <include package=".twitter_feed" />
 
 </configure>

src/design/plone/policy/upgrades.py

@@ -2,10 +2,10 @@
 from Acquisition import aq_base
 from collective.volto.blocksfield.field import BlocksField
 from copy import deepcopy
-from design.plone.policy.interfaces import IDesignPlonePolicySettings
 from design.plone.policy.setuphandlers import disable_searchable_types
 from design.plone.policy.setuphandlers import set_default_subsite_colors
 from design.plone.policy.utils import create_default_blocks
+from design.plone.policy.interfaces import IDesignPlonePolicySettings
 from plone import api
 from plone.app.upgrade.utils import installOrReinstallProduct
 from plone.dexterity.utils import iterSchemata
@@ -16,6 +16,7 @@
 from zope.component import getUtility
 from zope.schema import getFields
 
+
 import json
 import logging
 
@@ -364,3 +365,33 @@ def to_3100(context):
         logger.info("### Items that were not modified ###")
         for i, path in enumerate(not_modified):
             logger.info(f"[{i+1}/{len(not_modified)}] - {path}")
+
+
+def to_3101(context):
+    def remove_twitter(blocks_orig):
+        blocks = deepcopy(blocks_orig)
+        for key, block in blocks.items():
+            if block.get("@type", "") == "twitter_posts":
+                del blocks[key]
+
+        return blocks
+
+    for brain in api.portal.get_tool("portal_catalog")():
+        item = aq_base(brain.getObject())
+        for schema in iterSchemata(item):
+            for name, field in getFields(schema).items():
+                if name == "blocks":
+                    item.blocks = remove_twitter(item.blocks)
+
+                elif isinstance(field, BlocksField):
+                    value = deepcopy(field.get(item))
+                    if not value:
+                        continue
+                    try:
+                        blocks = value.get("blocks", {})
+                    except AttributeError:
+                        logger.warning(
+                            "[BLOCK] - {} (not converted)".format(brain.getURL())
+                        )
+                    if blocks:
+                        item.blocks = remove_twitter(blocks)

src/design/plone/policy/upgrades.zcml

@@ -181,4 +181,14 @@
         handler=".upgrades.to_3100"
         />
   </genericsetup:upgradeSteps>
+  <genericsetup:upgradeSteps
+      profile="design.plone.policy:default"
+      source="3100"
+      destination="3101"
+      >
+    <genericsetup:upgradeStep
+        title="Remove twitter blocks"
+        handler=".upgrades.to_3101"
+        />
+  </genericsetup:upgradeSteps>
 </configure>