-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session delegate to initializer #44
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5cc6bc9
Add session delegate to initializer
vani2 4e786ec
Change method signature for data
vani2 fd4fd16
update podfile.lock
vani2 5a2874c
Update github action for tests
vani2 37da482
update for min iOS 13
laqiguy 15fd13c
update macos runner version
laqiguy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,27 @@ | ||
Pod::Spec.new do |s| | ||
s.name = "Apexy" | ||
s.version = "1.7.3" | ||
s.version = "1.7.4" | ||
s.summary = "HTTP transport library" | ||
s.homepage = "https://github.com/RedMadRobot/apexy-ios" | ||
s.license = { :type => "MIT"} | ||
s.author = { "Alexander Ignatiev" => "[email protected]" } | ||
s.source = { :git => "https://github.com/RedMadRobot/apexy-ios.git", :tag => "#{s.version}" } | ||
|
||
s.ios.deployment_target = "11.0" | ||
s.tvos.deployment_target = "11.0" | ||
s.osx.deployment_target = "10.13" | ||
s.watchos.deployment_target = "4.0" | ||
s.ios.deployment_target = "13.0" | ||
s.tvos.deployment_target = "13.0" | ||
s.osx.deployment_target = "10.15" | ||
s.watchos.deployment_target = "6.0" | ||
|
||
s.swift_version = "5.3" | ||
|
||
s.subspec 'Core' do |sp| | ||
sp.source_files = "Sources/Apexy/*.swift" | ||
sp.source_files = "Sources/Apexy/**/*.swift" | ||
end | ||
|
||
s.subspec 'Alamofire' do |sp| | ||
sp.source_files = "Sources/ApexyAlamofire/*.swift" | ||
sp.dependency "Apexy/Core" | ||
sp.dependency "Alamofire", '~>5.0' | ||
sp.dependency "Alamofire", '~>5.6' | ||
end | ||
|
||
s.subspec 'URLSession' do |sp| | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a change in the public API, so I think you should update the major version in the
podspec
file. Or at least a minor version 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this extension at all now. it was implemented at time when
URLSession
had their async/await methods ready for use only since iOS 15. so to makeURLSessionClient
implementataion for iOS 13 and easy to read i have made this extension with async/await methods.now this methods are in
URLSession
available since iOS 13 so you can just delete this file and it will work justs fineThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also now you can get rid of
AsyncAwaitHelper
file too#42 will be fixed also