Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add core and threads for rhel.9.realtime #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add core and threads for rhel.9.realtime #209

wants to merge 1 commit into from
+19 −10

Conversation

geetikakay
Copy link
Contributor

rhel.9.realtime has SocketsCoresThreads

Short description:

realtime preference has spreadoptions across: SocketsCoresThreads and currently it is only supported for rhel.9.realtime.
cpu:
preferredCPUTopology: spread
spreadOptions:
across: SocketsCoresThreads

While creating a VM, it's required to pass sockets,cores and threads in a way that their product is cpu.guest(1)

More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:

@cnv-qe-bot1
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
  • to assign reviewer to PR use /assign-reviewer @<reviewer>
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest build-container: Retest build-container
  • /retest all: Retest all
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@cnv-qe-bot1 cnv-qe-bot1 mentioned this pull request Feb 1, 2025
Open
@geetikakay
Add core and threads for rhel.9.realtime
2aaf9ad 
- rhel.9.realtime has SocketsCoresThreads

Signed-off-by: Geetika Kapoor <[email protected]>
polarion-jenkins
polarion-jenkins approved these changes Feb 1, 2025
View reviewed changes
Copy link
Collaborator

@polarion-jenkins polarion-jenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D/S test tox -e verify-bugs-are-open passed: cnv-tests-tox-executor/6271

@geetikakay
Copy link
Contributor Author

/verified

dbasunag
dbasunag requested changes Feb 2, 2025
View reviewed changes
tests/infrastructure/instance_types/test_common_vm_preference.py
Comment on lines +67 to +82
vm_args = {
"client": client,
"name": f"rhel-vm-with-{preference_name}",
"namespace": namespace_name,
# TODO add corresponding images to the VM based on preference
"image": Images.Rhel.RHEL9_REGISTRY_GUEST_IMG,
"memory_guest": cluster_preference.instance.spec.requirements.memory.guest,
"cpu_sockets": cluster_preference.instance.spec.requirements.cpu.guest,
"vm_preference": cluster_preference,
}

if preference_name == "rhel.9.realtime":
vm_args.update({
"cpu_cores": cluster_preference.instance.spec.requirements.cpu.guest,
"cpu_threads": cluster_preference.instance.spec.requirements.cpu.guest,
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caller should pass whatever is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbasunag dbasunag dbasunag requested changes

@polarion-jenkins polarion-jenkins polarion-jenkins approved these changes

@RoniKishner RoniKishner RoniKishner approved these changes

@dshchedr dshchedr Awaiting requested review from dshchedr

@vsibirsk vsibirsk Awaiting requested review from vsibirsk

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
branch-main changes-requested-dbasunag lgtm-polarion-jenkins lgtm-RoniKishner needs-rebase size/S tox:verify-bugs-are-open:passed D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@geetikakay @cnv-qe-bot1 @dbasunag @RoniKishner @polarion-jenkins @redhat-cnv-qe-bot @redhat-cnv-qe-bot1