tests, net, checkup: Separate the DPDK checkup config helper #193
+77
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkups configurations are unique per individual checkup. The DPDK one has its own unique fields, some mandatory and some optional. This change separates the configuration creation for DPDK from the others. It provides clarity about which arguments are relevant to the DPDK checkup, expressing also which ones are mandatory and which ones are optional. In addition, typing has been added and a small simplification introduced to shorten the call-stack. Signed-off-by: Edward Haas <[email protected]>
|
Report bugs in Issues The following are automatically added:
Available user actions:
Supported /retest check runs
Supported labels
|
cnv-qe-bot1
requested review from
sbahar619,
dbasunag,
vsibirsk and
RoniKishner
polarion-jenkins
added
tox:verify-bugs-are-open:running
polarion-jenkins
approved these changes
Jan 28, 2025
polarion-jenkins
added
tox:verify-tc-requirement-polarion:passed
|
/lgtm |
yossisegev
approved these changes
Jan 28, 2025
dbasunag
approved these changes
Jan 28, 2025
|
@Anatw , can you please help verify this one? |
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-193 published |
sbahar619
reviewed
Jan 29, 2025
| Compose a dictionary with the ConfigMap data for the DPDK checkup. | ||
|
|
||
| Args: | ||
| timeout (str): Timeout to wait for the checkup to finish, in minutes. |
There was a problem hiding this comment.
It might be helpful to mention that the timeout argument expects the duration in minutes, with the 'm' suffix. Alternatively, you could have the user provide an integer value (representing minutes), and the function could automatically append the 'm' suffix. This way, the user wouldn't have to worry about formatting the duration correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
Separate the DPDK checkup config helper
What this PR does / why we need it:
The checkups configurations are unique per individual checkup. The DPDK one has its own unique fields, some mandatory and some optional.
This change separates the configuration creation for DPDK from the others.
It provides clarity about which arguments are relevant to the DPDK checkup, expressing also which ones are mandatory and which ones are optional.
In addition, typing has been added and a small simplification introduced to shorten the call-stack.
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
NONE