Add basic support for issue-config file defaults #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaarreell
force-pushed
the
defaults
branch
2 times, most recently
from
fd6ff9a
to
e71c4ed
Compare
|
Since i am reusing |
lukaszachy
reviewed
Nov 14, 2024
| # Iterate over issue actions. Take one, if it's not possible to finish it, | ||
| # put it back at the end of the queue. | ||
| while issue_actions: | ||
| action = issue_actions.pop(0) | ||
|
|
||
| ctx.logger.info(f"Processing {action.id}") | ||
|
|
||
| # update action object with default attributes when not present | ||
| action = _update_action_with_defaults(action, config.defaults) |
There was a problem hiding this comment.
Why is handling of defaults done here in the loop and not during config = IssueConfig.from_yaml_with_include call?
There was a problem hiding this comment.
Well, I guess I see that function for loading YAML, not doing semantic evaluation. Are you strongly against keeping it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.