Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add floorist plugin tests using a second cji #693

Merged
merged 15 commits into from
Sep 26, 2024

Conversation

prichard77
Copy link
Contributor

@prichard77 prichard77 commented Sep 17, 2024

@prichard77 prichard77 marked this pull request as draft September 17, 2024 15:41
@prichard77 prichard77 marked this pull request as ready for review September 17, 2024 18:29
@prichard77
Copy link
Contributor Author

.rhcicd/pr_check.sh Outdated Show resolved Hide resolved
.rhcicd/pr_check.sh Outdated Show resolved Hide resolved
.rhcicd/pr_check.sh Outdated Show resolved Hide resolved
.rhcicd/pr_check.sh Outdated Show resolved Hide resolved
@prichard77
Copy link
Contributor Author

/retest

.rhcicd/pr_check.sh Outdated Show resolved Hide resolved
@prichard77
Copy link
Contributor Author

I created an MR to update cji_smoke_tests.sh and was able to do a small bit of testing. When this update gets merged, we should be able to change the cji name and hopefully get closer to merging. I will go ahead and add the needed update to support this change as it should be benign. I only need to add an env var.

@prichard77
Copy link
Contributor Author

@prichard77
Copy link
Contributor Author

/retest

1 similar comment
@prichard77
Copy link
Contributor Author

/retest

.rhcicd/pr_check.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@vkrizan vkrizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vkrizan vkrizan merged commit 4d25d53 into RedHatInsights:master Sep 26, 2024
4 checks passed
This was referenced Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants