Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvement in Storage struct #248

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Minor improvement in Storage struct #248

merged 2 commits into from
Nov 27, 2023

Conversation

tisnik
Copy link
Collaborator

@tisnik tisnik commented Nov 27, 2023

Description

  • Minor improvement in Storage struct
  • Better error logging
  • Read support for sqlite3 (if needed)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Testing steps

To be checked on CI.

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@tisnik tisnik merged commit 625b5a4 into RedHatInsights:master Nov 27, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bee-lee Bee-lee Bee-lee approved these changes

@joselsegura joselsegura joselsegura approved these changes

@matysek matysek matysek approved these changes

@epapbak epapbak Awaiting requested review from epapbak

@JiriPapousek JiriPapousek Awaiting requested review from JiriPapousek

@juandspy juandspy Awaiting requested review from juandspy

@Jakub007d Jakub007d Awaiting requested review from Jakub007d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tisnik @matysek @joselsegura @Bee-lee