Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run notification and service log tests in pr_check #693

Closed
wants to merge 3 commits into from

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented Jan 17, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor (refactoring code, removing useless files)
  • Unit tests (no changes in the code)
  • Behavioral tests (no changes in the code)
  • Bump-up dependent library (no changes in the code)
  • Security fix in dependent library (no changes in the code)
  • Security fix in dependent library (changes made in the code)
  • Benchmarks (no changes in the code)
  • Documentation update
  • Configuration update

Testing steps

Please describe how the change was tested locally. If, for some reason, the testing was not done or not done fully, please describe what are the testing steps.

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@epapbak epapbak force-pushed the CCXDEV-11428 branch 4 times, most recently from 06fe69d to 6368a13 Compare January 17, 2024 17:05
@epapbak
Copy link
Collaborator Author

epapbak commented Jan 17, 2024

/retest

@epapbak epapbak force-pushed the CCXDEV-11428 branch 2 times, most recently from d3675a7 to 45bc676 Compare January 17, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant