Use clowder and kafka broker configuration from ioutils v1.25.2 #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epapbak
force-pushed
the
CCXDEV-12328
branch
2 times, most recently
from
8efa53f
to
2e0b7b2
Compare
Merged
4 tasks
epapbak
force-pushed
the
CCXDEV-12328
branch
from
3ab479d
to
85ae1ed
Compare
…pends on Kafka version
|
This functionality was delivered as part of #704 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
insights-operator-utilsv1.25.2 introduces the following reusable packages (across our services):In this PR we refactor the
ccx-notification-writerto use those. This is a first step towards moving the common/shared/similar code from our Go-based services related to Clowder, DB, and Kafka intoinsights-operator-utils.Most important change is that now we expect a list of broker addresses instead of a single broker address in the BrokerConfiguration structure. This is because we now expect Clowder to always provide the information of a multi-broker Kafka cluster.
Fixes CCXDEV-12328
Type of change
Testing steps
Please describe how the change was tested locally. If, for some reason, the testing was not done or not done fully, please describe what are the testing steps.
Checklist
make before_commitpasses