Add support for logout a client #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleviim
approved these changes
May 27, 2018
nirs
requested changes
Jul 17, 2018
| def client_bye(self): | ||
| log.info('client received "bye" message.') | ||
| reactor.stop() | ||
| os._exit(0) |
There was a problem hiding this comment.
sys.exit() is the proper way to exit. os._exit() needed only in special cases.
But I think that reactor.stop() should be enough to make the client terminate - see line 78.
| data = str(msg) | ||
| for client in self.clients: | ||
| if isinstance(client, PlayerProtocol): | ||
| if client.name == name: |
There was a problem hiding this comment.
It can be little nicer to do:
if client.name == name and isinstance(client, PlayerProtocol):
client.send_message(data)
Would be even nicer if we avoid checking the type of the client. Do we enforce unique client name for all clients?
| @@ -192,4 +199,11 @@ def render_POST(self, request): | |||
| except ValueError: | |||
| request.setResponseCode(http.BAD_REQUEST) | |||
| return b"Invalid rate value %r, expected number" % value | |||
| if "bye" in request.args: | |||
| name = request.args["bye"][0] | |||
There was a problem hiding this comment.
POST is used to change server state. I think we need different API to disconnect clients. Maybe:
DELETE /players/name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #296
First commit with backend support