Debugging "best" RTMPS connections from FlashPlayer

Red5 · Jun 20, 2016 · c4e2c38 · c4e2c38
1 parent e68d406
commit c4e2c38
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/main/java/org/red5/server/net/rtmp/RTMPConnection.java b/src/main/java/org/red5/server/net/rtmp/RTMPConnection.java
@@ -488,10 +488,8 @@ public boolean connect(IScope newScope, Object[] params) {
                 stopWaitForHandshake();
                 // once the handshake has completed, start needed jobs start the ping / pong keep-alive
                 startRoundTripMeasurement();
-            } else {
-                if (log.isDebugEnabled()) {
-                    log.debug("Connect failed");
-                }
+            } else if (log.isDebugEnabled()) {
+                log.debug("Connect failed");
             }
             return success;
         } catch (ClientRejectedException e) {
@@ -513,7 +511,7 @@ public void startWaitForHandshake() {
         try {
             waitForHandshakeTask = scheduler.schedule(new WaitForHandshakeTask(), new Date(System.currentTimeMillis() + maxHandshakeTimeout));
         } catch (TaskRejectedException e) {
-            log.error("WaitForHandshake task was rejected for " + sessionId, e);
+            log.error("WaitForHandshake task was rejected for {}", sessionId, e);
         }
     }
 
@@ -542,10 +540,10 @@ private void startRoundTripMeasurement() {
                 try {
                     keepAliveTask = scheduler.scheduleAtFixedRate(new KeepAliveTask(), pingInterval);
                     if (log.isDebugEnabled()) {
-                        log.debug("Keep alive scheduled for: {}", sessionId);
+                        log.debug("Keep alive scheduled for {}", sessionId);
                     }
                 } catch (Exception e) {
-                    log.error("Error creating keep alive job for: " + sessionId, e);
+                    log.error("Error creating keep alive job for {}", sessionId, e);
                 }
             }
         } else {