Fixed decoder state logic

Red5 · Apr 6, 2022 · 3a2cb95 · 3a2cb95
1 parent b8e7607
commit 3a2cb95
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/src/main/java/org/red5/server/net/protocol/RTMPDecodeState.java b/src/main/java/org/red5/server/net/protocol/RTMPDecodeState.java
@@ -7,8 +7,6 @@
 
 package org.red5.server.net.protocol;
 
-import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
-
 /**
  * Represents current decode state of the protocol.
  */
@@ -22,9 +20,6 @@ private enum State {
         DESTROYED; // Decoding is no longer required
     }
 
-    // atomic updater the current amount buffered
-    private final static AtomicIntegerFieldUpdater<RTMPDecodeState> amountUpdater = AtomicIntegerFieldUpdater.newUpdater(RTMPDecodeState.class, "decoderBufferAmount");
-
     /**
      * Session id to which this decoding state belongs.
      */
@@ -54,14 +49,13 @@ public int getDecoderBufferAmount() {
     }
 
     /**
-     * Specifies buffer decoding amount
+     * Specifies buffer decoding amount needed.
      * 
      * @param amount Buffer decoding amount
      */
     public void bufferDecoding(int amount) {
-        if (amountUpdater.addAndGet(this, amount) > 0) {
-            decoderState = State.BUFFER;
-        }
+        decoderState = State.BUFFER;
+        decoderBufferAmount = amount;
     }
 
     /**
@@ -85,12 +79,11 @@ public boolean canStartDecoding(int remaining) {
      * Starts decoding. Sets state to "ready" and clears buffer amount.
      */
     public void startDecoding() {
-        amountUpdater.set(this, 0);
         decoderState = State.OK;
+        decoderBufferAmount = 0;
     }
 
     public void stopDecoding() {
-        amountUpdater.lazySet(this, 0);
         decoderState = State.DESTROYED;
     }