Release Perfect Timing! - Audio Quantizer v0.21 (Beta) #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfillion
reviewed
Mar 3, 2024
Comment on lines
+41
to
+55
| function checkIMGUI() | ||
| local imgui_version, imgui_version_num, REAIMGUI_VERSION = r.ImGui_GetVersion() | ||
| local version_sum = 0 | ||
| REAIMGUI_VERSION = string.gsub(REAIMGUI_VERSION, '%p', "") | ||
| return REAIMGUI_VERSION | ||
| end | ||
|
|
||
|
|
||
| if not dofile(r.GetResourcePath() .. '/Scripts/ReaTeam Extensions/API/imgui.lua') then ------------IMGUI check----------------------- | ||
| r.ShowMessageBox("Please, install IMGUI extension from REAPACK.\nThanks!", "Ooops!", 0) | ||
| r.ReaPack_BrowsePackages('ReaImGui: ReaScript binding for Dear ImGui') | ||
| return false | ||
| else | ||
| REAIMGUI_VERSION = tonumber(checkIMGUI()) | ||
| if REAIMGUI_VERSION < 83 then ------------ IMGUI version check----- |
There was a problem hiding this comment.
This errors out if ReaImGui is not installed (missing imgui.lua), does not properly check its version, and does not activate backward-compatibility.
Correct usage is as follow:
local imgui_path = r.GetResourcePath() .. '/Scripts/ReaTeam Extensions/API/imgui.lua'
if not r.file_exists(imgui_path) then
-- ...
return
end
dofile(imgui_path) '0.8.3' -- version check + backward compat
-- from this point onward it's safe to use r.ImGui_* functions (only of v0.8.3)There was a problem hiding this comment.
Ok thanks! changing it and making a new pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.