Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: Use std::unique_ptr (C++11) where possible (bitcoin #11043) #1165

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

backport: Use std::unique_ptr (C++11) where possible (bitcoin #11043) #1165

wants to merge 14 commits into from

Commits on Dec 19, 2021

  1. Use unique_ptr for pwalletMain (CWallet)

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    d07571b View commit details
    Browse the repository at this point in the history

  2. Use unique_ptr for httpRPCTimerInterface (HTTPRPCTimerInterface)

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    18d9810 View commit details
    Browse the repository at this point in the history

  3. Use unique_ptr:s for {fee,short,long}Stats (TxConfirmStats)

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    5d588f6 View commit details
    Browse the repository at this point in the history

  4. Use unique_ptr for dbw (CDBWrapper)

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    4edadb1 View commit details
    Browse the repository at this point in the history

  5. Use unique_ptr for upnp_thread (boost::thread)

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    c74138a View commit details
    Browse the repository at this point in the history

  6. Use unique_ptr for sem{Addnode,Outbound} (CSemaphore)

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    6025059 View commit details
    Browse the repository at this point in the history

  7. Use unique_ptr for pfilter (CBloomFilter)

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    7525f30 View commit details
    Browse the repository at this point in the history

  8. Use unique_ptr for dbenv (DbEnv)

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    af7ed0b View commit details
    Browse the repository at this point in the history

  9. Use unique_ptr for pdbCopy (Db) and fix potential memory leak

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    9bd0285 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Use unique_ptr for pcoinscatcher/pcoinsdbview/pcoinsTip/pblocktree 

    * pcoinscatcher (CCoinsViewErrorCatcher)
* pcoinsdbview (CCoinsViewDB)
* pcoinsTip (CCoinsViewCache)
* pblocktree (CBlockTreeDB)
* Remove variables shadowing pcoinsdbview
    @practicalswift @fdoving
    practicalswift authored and fdoving committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    cf283ab View commit details
    Browse the repository at this point in the history

  2. Add MakeUnique (substitute for C++14 std::make_unique) 

    From @ryanofsky:s #10973. Thanks!
    @practicalswift @fdoving
    practicalswift authored and fdoving committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    d56ab5d View commit details
    Browse the repository at this point in the history

  3. Use MakeUnique<T>(...) instead of std::unique_ptr<T>(new T(...))

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    3e6fb31 View commit details
    Browse the repository at this point in the history

  4. Use MakeUnique<Db>(...)

    @practicalswift @fdoving
    practicalswift authored and fdoving committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    555ea4f View commit details
    Browse the repository at this point in the history

  5. Adjustments for Ravencoin

    @fdoving
    fdoving committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    22890a7 View commit details
    Browse the repository at this point in the history