Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL event.timestamp is not always unique #13019

Merged
merged 10 commits into from
Mar 4, 2024
Merged

SQL event.timestamp is not always unique #13019

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4c68dac
return ID instead of timestamp
vcidst Mar 1, 2024
d72db8a
order by both timestamp and ID
vcidst Mar 1, 2024
90c25b4
order events by ID
vcidst Mar 4, 2024
49d5208
add timestamp ordering to events
vcidst Mar 4, 2024
51f9fde
fix linting error
vcidst Mar 4, 2024
b283918
change event timestamps in test
vcidst Mar 4, 2024
76c64fe
add context in docstring and comment
vcidst Mar 4, 2024
ac219a1
add test to tracker store
vcidst Mar 4, 2024
5bcc809
undo changes to assertion
vcidst Mar 4, 2024
d67f233
add changelog
vcidst Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rasa/core/tracker_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,7 +1325,7 @@ def _event_query(
)
)

return event_query.order_by(self.SQLEvent.timestamp)
return event_query.order_by(self.SQLEvent.timestamp, self.SQLEvent.id)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the change to order by both? We do not need batch ordering, but simple overall ordering. The SQLEvent.id is unique and chronologically ordered by nature, which makes timestamp redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zackjn I've changed the order to order by ID


async def save(self, tracker: DialogueStateTracker) -> None:
"""Update database with events from the current conversation."""
Expand Down
Loading