Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit docs workflow to release docs for 3.6.x #12993

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Edit docs workflow to release docs for 3.6.x #12993

merged 3 commits into from
Jan 17, 2024

Conversation

sanchariGr
Copy link
Collaborator

@sanchariGr sanchariGr commented Jan 11, 2024

Proposed changes:

@sanchariGr sanchariGr marked this pull request as ready for review January 16, 2024 14:39
@sanchariGr sanchariGr requested a review from a team as a code owner January 16, 2024 14:39
@sanchariGr sanchariGr requested review from aerowithanl, a team, radovanZRasa and m-vdb and removed request for a team and radovanZRasa January 16, 2024 14:39
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12993--rasahq-docs-rasa-v2.netlify.app/docs/rasa

Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanchariGr not sure, but this workflow failed with

fatal: No names found, cannot describe anything.

Do you have an example of this script working correctly on the CI? If not, have you tried locally?

One thing I am confuse about, is that my understanding of the git describe comment is that it is not performing a fetch 🤔 but am I mistaken?

@sanchariGr
Copy link
Collaborator Author

sanchariGr commented Jan 17, 2024

@m-vdb I have the test results added in the PR description. The failure was with tag 3.5.18, which is expected.
Screenshot 2024-01-17 at 11 46 49
git fetch fetches all the tags available in origin so it was also fetching 3.7.0 and 3.8.0a9 (see here).
git describe --tags --abbrev=0 HEAD only gets the latest tag on a branch.

@m-vdb
Copy link
Collaborator

m-vdb commented Jan 17, 2024

ok gotcha, works for me. Something very weird is happening locally when I run the command. When I run it on main, it outputs 3.6.13, when I run it on 3.6.x, it output 3.6.15. In both cases that's different from what you have here

@sanchariGr
Copy link
Collaborator Author

Thats because this #12996 was not merged into main. So main changelog also is only updated until 3.6.13. Let me merge this and check.

@sanchariGr sanchariGr merged commit 8310899 into 3.6.x Jan 17, 2024
98 checks passed
@sanchariGr sanchariGr deleted the ATO-1944 branch January 17, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants