Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added space to include proper text in auto-generated docs #12709

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Added space to include proper text in auto-generated docs #12709

merged 2 commits into from
Aug 4, 2023

Conversation

sanchariGr
Copy link
Collaborator

@sanchariGr sanchariGr commented Aug 4, 2023 •
edited
Loading

Proposed changes:

  • Adding a space between name and colon shows up the proper text in autogenerated text
  • Updated pydoc-markdown to 4.7.0 (latest possible)
  • Ran suggested update npx browserslist@latest --update-db which modified yarn.lock
  • The format of the text generated is still not correct so creating an issue with pydoc to help resolve the problem.

Example of generated doc :
Screenshot 2023-08-04 at 15 00 13

@sanchariGr sanchariGr requested a review from a team as a code owner August 4, 2023 13:26
@sanchariGr sanchariGr requested review from vcidst and a team and removed request for a team August 4, 2023 13:27
vcidst
vcidst approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the award for the most mysterious Bugfix goes to...

@vcidst
Copy link
Contributor

vcidst commented Aug 4, 2023

I'll wait for the documentation to be generated as well

@sanchariGr sanchariGr requested a review from a team August 4, 2023 13:35
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

🚀 A preview of the docs have been deployed at the following URL: https://12709--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sanchariGr sanchariGr merged commit dcaead3 into main Aug 4, 2023
97 of 98 checks passed
@sanchariGr sanchariGr deleted the ATO-1301 branch August 4, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcidst vcidst vcidst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanchariGr @vcidst