Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intentless #12706

Merged
merged 6 commits into from
Aug 16, 2023
Merged

intentless #12706

merged 6 commits into from
Aug 16, 2023

Conversation

twerkmeister
Copy link
Contributor

@twerkmeister twerkmeister commented Aug 2, 2023 •
edited
Loading

Proposed changes:

  • split up the knowledge and chitchat better in the prompt
  • added chitchat as a default flow
  • added stack frame for intentless policy
  • made intentless policy frame the default for chitchat

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@twerkmeister twerkmeister marked this pull request as ready for review August 16, 2023 09:52
@twerkmeister twerkmeister requested a review from a team as a code owner August 16, 2023 09:52
@twerkmeister twerkmeister requested a review from tmbo August 16, 2023 09:52
@twerkmeister twerkmeister changed the title intentless wip intentless Aug 16, 2023
tmbo
tmbo approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rasa/cdu/flow_stack.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@twerkmeister @tmbo
Update rasa/cdu/flow_stack.py
18d5b9f 
Co-authored-by: Tom Bocklisch <[email protected]>
@twerkmeister twerkmeister merged commit e370ce0 into dm2 Aug 16, 2023
95 of 96 checks passed
@twerkmeister twerkmeister deleted the ENG-431-intentless-integration branch August 16, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twerkmeister @tmbo