Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs on sending Conversation Events to multiple DBs #12677

Merged
merged 5 commits into from
Jul 20, 2023

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Jul 19, 2023

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt marked this pull request as ready for review July 19, 2023 10:21
Comment on lines 203 to 204
Each consumer group will process all events independent of each other
(in a sense, each group has their own reference to the last event they have processed).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also link to a reference, maybe this?

@Tawakalt Tawakalt requested a review from vcidst July 19, 2023 14:48
@Tawakalt Tawakalt enabled auto-merge July 20, 2023 11:11
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Tawakalt Tawakalt merged commit a958ec2 into main Jul 20, 2023
98 checks passed
@Tawakalt Tawakalt deleted the ATO-433-update-docs-on-sending-events-to-multiple-dbs branch July 20, 2023 11:19
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12677--rasahq-docs-rasa-v2.netlify.app/docs/rasa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants