Fixing CI for DM2 #12652
Fixing CI for DM2 #12652
Conversation
|
Still, 2 test cases fail:
|
|
@tmbo I had to push this commit to fix the |
|
🚀 A preview of the docs have been deployed at the following URL: https://12652--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
| tracker = ( | ||
| await app.ctx.agent.processor.fetch_full_tracker_with_initial_session( | ||
| conversation_id, | ||
| output_channel=CollectingOutputChannel(), | ||
| ) |
There was a problem hiding this comment.
why is this change necessary? :)
There was a problem hiding this comment.
I see this is related to your comment above @m-vdb, I read the linked convo but can't tell what's the right way from that.
There was a problem hiding this comment.
I reverted it back to the way it was prior to changes on the dm2 branch, cf. this comment. Does it make sense?
| @@ -75,9 +75,11 @@ def test_load_from_dict( | |||
| ) | |||
|
|
|||
| assert isinstance(actual, E2EImporter) | |||
| assert isinstance(actual.importer, ResponsesSyncImporter) | |||
| assert isinstance(actual._importer._importer, ResponsesSyncImporter) | |||
There was a problem hiding this comment.
that's one of Danil's changes. Not sure exactly why, I presume it's because some of the importer underlying code changed?
There was a problem hiding this comment.
ah yeah we added FlowSyncImporter in the mix
Summary
rasa.server.pyrasa.sharedpackage