Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly script #12569

Merged
merged 11 commits into from
Jul 21, 2023
Merged

Fix nightly script #12569

merged 11 commits into from
Jul 21, 2023

Conversation

sanchariGr
Copy link
Collaborator

@sanchariGr sanchariGr commented Jun 27, 2023 •
edited
Loading

Proposed changes:

@sanchariGr sanchariGr requested a review from a team as a code owner June 27, 2023 13:48
@sanchariGr sanchariGr requested review from aerowithanl and ancalita and removed request for a team June 27, 2023 13:48
ancalita
ancalita reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only just noticed this PR, apologies, it slipped my radar 🙈

.github/workflows/nightly_release.yml Outdated Show resolved Hide resolved
m-vdb
m-vdb requested changes Jul 18, 2023
View reviewed changes
.github/workflows/nightly_release.yml Outdated Show resolved Hide resolved
@sanchariGr sanchariGr force-pushed the fix_nightly branch 4 times, most recently from 13fec1c to 75068ef Compare July 19, 2023 12:38
@sanchariGr sanchariGr requested a review from a team as a code owner July 19, 2023 12:38
@sanchariGr sanchariGr force-pushed the fix_nightly branch 3 times, most recently from 42c0d0a to 7d59d4f Compare July 19, 2023 14:51
@sanchariGr sanchariGr removed request for a team and aerowithanl July 19, 2023 15:01
@sanchariGr sanchariGr force-pushed the fix_nightly branch 3 times, most recently from 52a692e to 6040091 Compare July 19, 2023 15:22
@sanchariGr sanchariGr requested a review from ancalita July 19, 2023 15:39
@sanchariGr sanchariGr requested a review from m-vdb July 19, 2023 15:39
@sanchariGr sanchariGr changed the title Add numpy dependency install and test workflow Fix nightly script Jul 19, 2023
m-vdb
m-vdb approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks @sanchariGr ! Well done 🙌🏻

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sanchariGr sanchariGr merged commit 37cbbd7 into main Jul 21, 2023
98 checks passed
@sanchariGr sanchariGr deleted the fix_nightly branch July 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita left review comments

@m-vdb m-vdb m-vdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanchariGr @m-vdb @ancalita