Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 update balance assertion #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Aboudjem
Copy link

@Aboudjem Aboudjem commented May 9, 2023

Updated the balance assertion in the test.

Previously, it was checking that attacker's balance must be higher than 9900 ether, which always pass since the initial balance was 10000.

Now, it checks for a balance greater than 19900 (initial balance 10000 + 9900 from hacking)

@RareSkills
Copy link
Owner

this is a valid PR, but we'll merge it after the contest to keep things consistent.

Repository owner deleted a comment from akashakki Mar 1, 2024
@tanim0la
Copy link
Collaborator

tanim0la commented Sep 7, 2024

@RareSkills ok to merge this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants