修复当不使用专用的下载器而经常报错的问题 #22
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanKKI
requested changes
Apr 19, 2023
| @@ -87,7 +87,8 @@ def check_complete(self): | |||
| return | |||
|
|
|||
| # 过滤标记为做种的已完成项目 | |||
| completed = [item for item in completed if not redisDB.is_seeding(item.hash)] | |||
| # there might be torrents that are already in the downloader but not added by us | |||
| completed = [item for item in completed if redisDB.get(item.hash) and not redisDB.is_seeding(item.hash)] | |||
There was a problem hiding this comment.
我没记错的话， 一个文件完成之后会从 redis 把它的相关信息删除掉，
这里 redisDB.get(hash) 一定没内容
There was a problem hiding this comment.
如果这个种子不是由本程序添加的而是由用户直接向下载器添加的话，就会导致下面的rename操作失败。redis里面应该没有用户手动添加的种子的信息吧。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题表现：如果不使用给BangumiBot专用的下载器，而是连接一个已经有种子的下载器的话，BangumiBot会尝试在redis数据库中查找这些种子的信息。因为这些种子信息在redis中不存在，rename函数中的info为None，所以会报错。
PS: 因为不知道贵项目使用的什么代码格式化器，就没有格式化这一行过长的代码。