Rewrite #124
Merged
Rewrite #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this branch is an attempt to decrease the amount of insane technical debt this project has
the crate should focus on interacting with jellyfin, how to handle configs can be left up to the program
Moved button struct from config to jellyfin Created a RawSession struct so i can have a Session struct without needing to unwrap NowPlayingItem Added get_image() fn to Session Added get_buttons() fn to Session Created imgur file (empty for now) Added reconnect to Client in case discord rpc disconnects Added logic to set_activity() fn Might be some small changes that ive forgot to include around here
Everything should in theory be able to display properly now, next step is to readd the features I originally had
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jellyfin-RPC rewrite that makes code actually maintainable