Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation error of ngsipayloadattr #351

Conversation

djs0109
Copy link
Contributor

@djs0109 djs0109 commented Nov 15, 2024

closes #350

@djs0109 djs0109 requested a review from SystemsPurge November 19, 2024 15:12
@djs0109
Copy link
Contributor Author

djs0109 commented Nov 19, 2024

@SystemsPurge I will add a test case for that

@djs0109
Copy link
Contributor Author

djs0109 commented Nov 19, 2024

It is done now

Copy link
Collaborator

@SystemsPurge SystemsPurge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djs0109 This works well. Pipeline is failing on coverage due to a failing test ( that seemingly has nothing to do with this ) so maybe merging master first is in order ? lgtm in any case

@djs0109
Copy link
Contributor Author

djs0109 commented Nov 20, 2024

Great it is fixed now

@djs0109 djs0109 merged commit 71404cc into master Nov 20, 2024
1 check passed
@djs0109 djs0109 deleted the 350-NgsiPayloadAttr-model-in-subcriptions-should-not-validate-value-type branch November 20, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NgsiPayloadAttr model in subcriptions should not validate value type
2 participants