Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

215 mark quantumleap subscription as deprecated #263

Merged
merged 14 commits into from
Apr 17, 2024

Conversation

SystemsPurge
Copy link
Collaborator

@SystemsPurge SystemsPurge commented Mar 26, 2024

closes #215
Marked quantumleap susbscription deprecated as needed. IdPattern was also added as query parameter but was not able to be tested properly.

@SystemsPurge SystemsPurge requested a review from djs0109 March 26, 2024 08:44
@djs0109
Copy link
Contributor

djs0109 commented Mar 26, 2024

@SystemsPurge, could you add a test function in tests/clients/test_ngsi_v2_timeseries.py to validate the implemented idPattern functionality?

@SystemsPurge
Copy link
Collaborator Author

SystemsPurge commented Mar 28, 2024

@djs0109 Test function is implemented and should work properly now. I just wanted to point out a few things. The setup and teardown methods do not work in the test ( at least in test_ngsi_v2_timeseries ) because the servicepath is hard set on /static, whereas the servicepath in settings ( where it is taken from in the setUp method ) is a different one. No entities are added or removed before and after each test. The test for idPattern is a bit convoluted because in the case where we expect 0 results, an error must be caught, whereas in any other case a value calculated from the response is compared to an expected value. Suggestions on how to write it in a more simplified manner ( if possible ) are definitely welcome.
I've had to go through the quantumleap code to figure out the regex OP used for the SQL queries, and its the '~*' op ( case insensitive POSIX ), same as it stands in ORION documentation, only with an extra ($|.*) tacked on in the end, i guess to indicate an automatic search as a subexpression.
I'm not certain but it seemed to me that it only worked once i set the QL version to edge to correspond to the master branch in the github repo.

tests/clients/test_ngsi_v2_timeseries.py Outdated Show resolved Hide resolved
@djs0109 djs0109 merged commit bbd073e into master Apr 17, 2024
1 check was pending
@djs0109 djs0109 deleted the 215-Mark-Quantumleap-subscription-as-deprecated branch April 17, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark Quantumleap subscription as deprecated
2 participants