fix: Session added as optional parameter to enable tls communication … #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djs0109
commented
Mar 4, 2024
filip/utils/cleanup.py
Outdated
|
|
||
|
|
||
| def clear_context_broker(url: str, fiware_header: FiwareHeader): | ||
| def clear_context_broker(url: str, fiware_header: FiwareHeader, session: Session = None ): |
There was a problem hiding this comment.
Instead of adding Session as a parameter, I will suggest to use cb_client: ContextBrokerClient = None. And then reuse the given client below. This can be beneficial for maintenance, because if later we add or fix something in the client class, then we don't need to change here again
There was a problem hiding this comment.
And maybe make url no more as required variable
filip/utils/cleanup.py
Outdated
| @@ -45,20 +47,21 @@ def clear_context_broker(url: str, fiware_header: FiwareHeader): | |||
| assert len(client.get_registration_list()) == 0 | |||
|
|
|||
|
|
|||
| def clear_iot_agent(url: Union[str, AnyHttpUrl], fiware_header: FiwareHeader): | |||
| def clear_iot_agent(url: Union[str, AnyHttpUrl], fiware_header: FiwareHeader, session: Session = None): | |||
There was a problem hiding this comment.
Same as above, iota_client
filip/utils/cleanup.py
Outdated
| @@ -72,12 +75,13 @@ def clear_iot_agent(url: Union[str, AnyHttpUrl], fiware_header: FiwareHeader): | |||
| assert len(client.get_group_list()) == 0 | |||
|
|
|||
|
|
|||
| def clear_quantumleap(url: str, fiware_header: FiwareHeader): | |||
| def clear_quantumleap(url: str, fiware_header: FiwareHeader, session: Session = None): | |||
There was a problem hiding this comment.
Same as above, ql_client
filip/utils/cleanup.py
Outdated
|
|
||
|
|
||
| def clean_test(*, | ||
| fiware_service: str, | ||
| fiware_servicepath: str, | ||
| cb_url: str = None, | ||
| iota_url: Union[str, List[str]] = None, | ||
| ql_url: str = None) -> Callable: | ||
| ql_url: str = None, | ||
| session: Session = None) -> Callable: |
There was a problem hiding this comment.
Same as above, three clients
…enable TLS connections for self-signed certificates.
…bility-in-all-cleanup-py-functions' into 248-support-tls-connection-possibility-in-all-cleanup-py-functions
djs0109
commented
Apr 16, 2024
djs0109
commented
Apr 16, 2024
djs0109
commented
Apr 16, 2024
djs0109
commented
Apr 16, 2024
…all-cleanup-py-functions # Conflicts: # CHANGELOG.md
|
@mwr-ebc it looks good to me for now. If you see no problem in the last commit I just made, then we can merge it |
mwr-ebc
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #248